Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the message previews text displayed in Favourites/People/Rooms tabs #4918

Open
pixlwave opened this issue Sep 27, 2021 · 1 comment
Open

Update the message previews text displayed in Favourites/People/Rooms tabs #4918

pixlwave opened this issue Sep 27, 2021 · 1 comment
Labels
X-Needs-Design May require input from the design team Z-D1 Issues that can impact the Day-2 retention Z-Impact-3 Z-Papercuts Visible. Impactful. Predictable to action. Z-Visibility-2

Comments

@pixlwave
Copy link
Member

pixlwave commented Sep 27, 2021 •
edited
Loading

Following on from #4451, the strings displayed in the rooms lists can be unhelpful for some message types.

Media shows without any indication of the attachment type:

Alice: File Name

Replies show who was replied to but no content:

Alice: In reply to Bob

It would be nice to match the strings used for notifications in #4132, however it would be worth thinking about this a bit given the current sender name prefix style:

Alice: replied Hello
Alice: sent a Voice Message

@niquewoodhouse I think you mentioned about whether having the sender name has value in DMs for example.

Update: An additional message type that needs to be considered is when a room has been created but has no other events that should be displayed. Using the creation event gives the string:

∙ You created and configured the room.

Screenshot of these:
IMG_0165
@pixlwave pixlwave added Z-Impact-3 Z-Papercuts Visible. Impactful. Predictable to action. Z-Visibility-2 design X-Needs-Design May require input from the design team and removed design labels Sep 27, 2021
@niquewoodhouse
Copy link

niquewoodhouse commented Sep 28, 2021 •
edited
Loading

Will benchmark against

  • Telegram
  • Whatsapp
  • Discord
  • Slack

@pixlwave pixlwave mentioned this issue Sep 29, 2021
Closed
@manuroe manuroe added the Z-D1 Issues that can impact the Day-2 retention label Oct 12, 2021
@niquewoodhouse niquewoodhouse self-assigned this Oct 19, 2021
@daniellekirkwood daniellekirkwood changed the title Update the message text displayed in Favourites/People/Rooms tabs Update the message previews text displayed in Favourites/People/Rooms tabs Nov 15, 2021
@niquewoodhouse niquewoodhouse removed their assignment Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
X-Needs-Design May require input from the design team Z-D1 Issues that can impact the Day-2 retention Z-Impact-3 Z-Papercuts Visible. Impactful. Predictable to action. Z-Visibility-2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@niquewoodhouse @pixlwave @manuroe