Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default app state inaccurate while syncing #5343

Open
nadonomy opened this issue Jan 5, 2022 · 5 comments
Open

Default app state inaccurate while syncing #5343

nadonomy opened this issue Jan 5, 2022 · 5 comments
Labels
A-Room-List O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@nadonomy
Copy link
Contributor

nadonomy commented Jan 5, 2022

Steps to reproduce

Sync a large account. Observe the client shows misleading content to the user as if their rooms/account don't exist at all:

image image

Reported by @InezMc

Outcome

We shouldn't display content which misleads the user into thinking all their data may be missing. We should indicate loading consistently as some tabs show a spinner and others don't.

Your phone model

No response

Operating system version

No response

Application version

No response

Homeserver

No response

Will you send logs?

No

@nadonomy nadonomy added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Jan 5, 2022
@nadonomy
Copy link
Contributor Author

nadonomy commented Jan 5, 2022

Related: @BillCarsonFr also notes the left panel loading state needs attention too as it's equally misleading/can lack spaces.

If we're syncing a large account I wonder if we should use a loading state for the entire app?

@BillCarsonFr
Copy link
Member

Also notice that it's a regular incremental sync after opening the app (not an initial sync).
I initialy thought that it was related to space hierachy (?) beeing very slow to resolve (or failing?) thus preventing the home to display known rooms as it doesn't now what to show (as it should be filtered by a space)

@InezMc
Copy link

InezMc commented Jan 5, 2022

It was odd /unexpected as I had been using the app throughout the day and this occured at the end of the day. So it was not due to opening the app after a few days or hours. It may be explained by me closing the app and then restarting.

@thibaultamartin
Copy link
Contributor

It happens to me fairly regularly, I think once in a month on average. I assumed the app was aggressively clearing cache regularly, since the behaviour is very similar when I clear cache

@nadonomy nadonomy changed the title Default app state inaccurate and misleading during long syncs Default app state inaccurate and misleading while syncing Jan 5, 2022
@nadonomy nadonomy changed the title Default app state inaccurate and misleading while syncing Default app state inaccurate while syncing Jan 5, 2022
@pixlwave
Copy link
Member

This looks as though it is the result of an inconsistency/corruption of the store, at which point the store is reset and an initial sync will take place. It would probably be sensible to get a rageshake linked to the issue to confirm though.

@niquewoodhouse, I seem to remember we discussed about skeleton screens for #4829 but decided there wasn't anywhere they would fit? Maybe that would be the right behaviour when an initial sync is taking place?

@pixlwave pixlwave added A-Room-List O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Room-List O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Development

No branches or pull requests

5 participants