Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Threads with replies sometimes don't display correctly #5832

Closed
novocaine opened this issue Mar 16, 2022 · 2 comments · Fixed by matrix-org/matrix-ios-sdk#1412
Closed

Threads with replies sometimes don't display correctly #5832

novocaine opened this issue Mar 16, 2022 · 2 comments · Fixed by matrix-org/matrix-ios-sdk#1412
Assignees
@ismailgulek
Labels
A-Threads Message threading to simplify the Timeline O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Labs Z-ThreadsInternalTesting Issue found while testing Threads internally

Comments

@novocaine
Copy link

Steps to reproduce

  1. Threads list in Threads P0 room

Outcome

Some thread previews show replies to (null), but these look fine in other clients

ima_acab8d3

Sometimes clicking into these threads shows blank

ima_a1c5a75

Sometimes I can view the thread, but there are a lot of nulls

ima_f6ee2a6

Your phone model

Iphone X

Operating system version

14.6

Application version

1.8.7 20220316153033

Homeserver

matrix.org

Will you send logs?

No
@novocaine novocaine added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems A-Threads Message threading to simplify the Timeline S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience Z-ThreadsInternalTesting Issue found while testing Threads internally labels Mar 16, 2022
@ismailgulek ismailgulek self-assigned this Mar 16, 2022
@novocaine
Copy link
Author

According to @ismailgulek on the nulls

it seems like due to missing is_falling_back keys in events. When they're omitted, i'm treating those events as replies.
we had some issues around it before, so i wonder the issue you mentioned is still visible on new threads

@ismailgulek ismailgulek mentioned this issue Mar 17, 2022
Merged
@ismailgulek
Copy link
Contributor

Mentioned PR should fix the empty screen case. I won't do anything about null replies, as they should be seen only for some old thread events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ismailgulek ismailgulek

Labels
A-Threads Message threading to simplify the Timeline O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Labs Z-ThreadsInternalTesting Issue found while testing Threads internally
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix thread events ordering matrix-org/matrix-ios-sdk
2 participants
@novocaine @ismailgulek