Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publishing room to homeserver room directory should not require m.room.canonical_alias permission #287

Open
CromFr opened this issue May 28, 2020 · 2 comments
Labels
T-Enhancement X-Needs-Product More input needed from the Product team

Comments

@CromFr
Copy link

CromFr commented May 28, 2020

image

Description

On current riot.im/app (1.6.2), not having the m.room.canonical_alias room permission disables all controls in Room settings -> Room Addresses, including the Publish this room to the public in tcharles.fr's room directory? switch.
I don't think this is expected behaviour as the permission for this feature is set in Synapse config (room_list_publication_rules), and querying directly the endpoint using curl (PUT on _matrix/client/r0/directory/list/room/:roomID) is still allowed without having the m.room.canonical_alias permission.

Steps to reproduce

  • Using a default synapse instance (or matrix.org)
  • Create an empty room
  • Demote yourself to Default or invite a new user
  • Open Room settings -> Room Addresses, the publish button is disabled and can't be toggled.

Logs being sent: no

Version information

  • Platform: web
  • Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0
  • OS: Windows
  • URL: riot.im/app
@mrjohnson22
Copy link

Note that Element Android doesn't have this restriction (v1.0.13 at the time of writing, but possibly older versions as well).

@emorrp1
Copy link

emorrp1 commented Jan 21, 2021

element-android 1.0.12 (f-droid version) says "This server requires you to be a moderator in the room to edit its room list entry"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement X-Needs-Product More input needed from the Product team
Projects
None yet
Development

No branches or pull requests

4 participants