Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If an old room version forgets it's been upgraded we should still ignore it if we are in a newer version of the room #11724

Open
ara4n opened this issue Dec 25, 2019 · 2 comments

Comments

@ara4n
Copy link
Member

ara4n commented Dec 25, 2019

No description provided.

@tulir
Copy link
Contributor

tulir commented Dec 25, 2019

This sounds dangerous, since anyone can create a room with any predecessor they want. If someone then joined a room with a malicious predecessor without realizing it, they might have some rooms inexplicably disappear from their room list.

There might also be legitimate use cases for a predecessor that isn't an upgrade, e.g. forking a room into a more specific topic

@turt2live
Copy link
Member

We could probably cache the tombstones for rooms more aggressively than other state, though it starts to be subject to #7843

@MadLittleMods MadLittleMods changed the title if an old room version forgets it's been upgraded we should still ignore it if we are in a newer version of the room If an old room version forgets it's been upgraded we should still ignore it if we are in a newer version of the room Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants