Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message for invalid m.room.encryption event is very bad #14290

Closed
tulir opened this issue Jul 2, 2020 · 1 comment
Closed

Error message for invalid m.room.encryption event is very bad #14290

tulir opened this issue Jul 2, 2020 · 1 comment
Labels

Comments

@tulir
Copy link
Contributor

tulir commented Jul 2, 2020

Description

When sending a message to a room that contains a m.room.encryption event that riot can't handle (e.g. redacted, sent incorrectly, etc), riot shows an extremely unhelpful "Your message was not sent" notification. The notification contains absolutely no information why it was not sent, and it offers a "Resend message" button that doesn't work.

Steps to reproduce

  • Send a m.room.encryption state event with an unsupported algorithm or redact an existing m.room.encryption event
  • Try to send a message

Expected result: useful error message that says the room is misconfigured or that the server is hiding the configuration, maybe offer a button to send a fixed encryption event if the user is admin.

Actual result: useless and confusing error message

image

This might also apply for

Version information

  • Platform: web
  • Browser: Firefox 79.0b2
  • OS: Ubuntu 20.04
  • URL: riot.im/develop
@tulir tulir added the T-Defect label Jul 2, 2020
@t3chguy
Copy link
Member

t3chguy commented Jul 2, 2020

@t3chguy t3chguy closed this as completed Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants