Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breadcrumbs that lead to other spaces require 2 clicks to work #18032

Closed
robintown opened this issue Jul 16, 2021 · 4 comments · Fixed by matrix-org/matrix-react-sdk#6399
Closed

Breadcrumbs that lead to other spaces require 2 clicks to work #18032

robintown opened this issue Jul 16, 2021 · 4 comments · Fixed by matrix-org/matrix-react-sdk#6399
Assignees
@t3chguy
Labels
A-Breadcrumbs A-Pills A-Room-List S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression X-Release-Blocker

Comments

@robintown
Copy link
Member

robintown commented Jul 16, 2021 •
edited
Loading

as of matrix-org/matrix-react-sdk#6391 (I assume)
@robintown robintown added T-Defect A-Breadcrumbs X-Regression X-Release-Blocker S-Major Severely degrades major functionality or product features, with no satisfactory workaround S-Minor Impairs non-critical functionality or suitable workarounds exist and removed S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Jul 16, 2021
@robintown
Copy link
Member Author

Same thing happens if you try to go to a room in a different space via the message forward dialog

@SimonBrandner SimonBrandner mentioned this issue Jul 17, 2021
Closed
@SimonBrandner
Copy link
Contributor

The same thing causes pills to break. Console shows

Screenshot_20210717_153200

@SimonBrandner SimonBrandner added A-Pills A-Room-List S-Major Severely degrades major functionality or product features, with no satisfactory workaround and removed S-Minor Impairs non-critical functionality or suitable workarounds exist labels Jul 17, 2021
@t3chguy
Copy link
Member

t3chguy commented Jul 17, 2021 •
edited
Loading

What do pills have to do with that error? Pills shouldn't be interacting with the room list store

Your other issue had the missing context. Clicking them is broken

@SimonBrandner
Copy link
Contributor

SimonBrandner commented Jul 17, 2021 •
edited
Loading

Well, neither should the forward dialog. The fact is that room-switching seems to be partially broken and when it breaks that is the error we get. So I assumed it's related to that change but it of course can be unrelated 🤷‍♂️

(to be clear I meant room pills)

@t3chguy t3chguy self-assigned this Jul 19, 2021
@t3chguy t3chguy mentioned this issue Jul 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Breadcrumbs A-Pills A-Room-List S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression X-Release-Blocker
Projects
None yet
Milestone
No milestone
3 participants
@t3chguy @SimonBrandner @robintown