Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unverified session UI implies that it can successfully request encryption keys #18652

Closed
1 task
kittykat opened this issue Aug 20, 2021 · 1 comment
Closed
1 task

Unverified session UI implies that it can successfully request encryption keys #18652

kittykat opened this issue Aug 20, 2021 · 1 comment
Labels
A-E2EE A-E2EE-SAS-Verification O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Papercuts Visible. Impactful. Predictable to action.

Comments

@kittykat
Copy link
Contributor

kittykat commented Aug 20, 2021 •
edited by Palid
Loading

Steps to reproduce

  1. Log into a new session
  2. "Verify this login" -> "Skip"
  3. "Are you sure?" -> "Skip"
  4. View an encrypted room with a backlog

What happened?

Screenshot from 2021-08-20 10-24-06

What did you expect?

This session will not be able to successfully request encryption keys until it is verified so the error message should not let me re-request keys. The error message should tell me to verify my session first.

🛡️ ** Unable to decrypt: you have not verified this session.**
[Verify this session](link to popup) using one of your other sessions to request encryption keys.

Or

🛡️ ** Unable to decrypt: the sender's device has not sent us the keys for this message.**
[Verify this session](link to popup) using one of your other sessions to request encryption keys.

Complicated because they need to verify against the correct session. Maybe we can assume that all their other sessions are verified against each other? Then we could check if this session is not verified against any other session before showing the above error. The bug could still persist for people who has ended up with two sets of sessions which are not verified against each other.

S-Major because clicking the "re-request encryption keys" fails silently so user is unaware that there is a problem and not able to try a workaround.
O-Frequent because it happens every time a new session is started and verification is skipped (based on other tickets and chat, verification is confusing to many new users).

Acceptance criteria

  • Error message for an unverified session communicating that session must be verified before a successful key request is possible.

Out of scope

Verified session failing to request keys because it is not verified against the needed sessions - may need new issue but might not be resolvable.

Operating system

Arch Linux

Browser information

Chromium Version 92.0.4515.131 (Official Build)

URL for webapp

develop.element.io

Have you submitted a rageshake?

No

Related: #18881
@kittykat kittykat added T-Defect S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-E2EE A-E2EE-SAS-Verification Z-Papercuts Visible. Impactful. Predictable to action. O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Aug 20, 2021
@kittykat kittykat changed the title Unverified session UI implies that it can request encryption keys Unverified session UI implies that it can successfully request encryption keys Aug 20, 2021
@Palid Palid mentioned this issue Sep 3, 2021
Closed
@richvdh
Copy link
Member

richvdh commented Mar 15, 2023

We no longer have these "re-request encryption keys" buttons, so this is resolved.

@richvdh richvdh closed this as completed Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-E2EE A-E2EE-SAS-Verification O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Papercuts Visible. Impactful. Predictable to action.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kittykat @MadLittleMods @richvdh