Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide "Edit" Message action bar button for m.room.message hidden timeline events #19878

Closed
t3chguy opened this issue Nov 24, 2021 · 0 comments · Fixed by matrix-org/matrix-react-sdk#7226
Closed

Hide "Edit" Message action bar button for m.room.message hidden timeline events #19878

t3chguy opened this issue Nov 24, 2021 · 0 comments · Fixed by matrix-org/matrix-react-sdk#7226
Assignees
@t3chguy
Labels
A-DevTools /devtools, show hidden events, etc. A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@t3chguy
Copy link
Member

t3chguy commented Nov 24, 2021

e.g edits, but clicking it just bricks that event tile and doesn't allow you to edit anything
@SimonBrandner SimonBrandner added A-DevTools /devtools, show hidden events, etc. A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect labels Nov 24, 2021
@germain-gg germain-gg changed the title We show an edit MAB button on m.room.message hidden timeline events Hide "Edit" Message action bar button for m.room.message hidden timeline events Nov 25, 2021
@t3chguy t3chguy self-assigned this Nov 29, 2021
@t3chguy t3chguy mentioned this issue Nov 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-DevTools /devtools, show hidden events, etc. A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't show edit button for hidden edit events matrix-org/matrix-react-sdk
2 participants
@t3chguy @SimonBrandner