Docker image not picking up the correct runtime VERSION variable

[turt2live]

[turt2live]

note that this has the effect of causing eternal upgrade notifications - the docker image writes /version correctly, but clearly doesn't set VERSION, so spawns a loop of no-op updates.

[jaller94]

• Also, the /version that gets written to Docker and is used for update checking uses the Git Tag, not $VERSION.

https://github.com/vector-im/element-web/blob/b3c5bb899bed14f3dbb6355960a98db42e04be47/scripts/docker-write-version.sh#L5

https://github.com/vector-im/element-web/blob/b3c5bb899bed14f3dbb6355960a98db42e04be47/scripts/docker-write-version.sh#L7

https://github.com/vector-im/element-web/blob/b3c5bb899bed14f3dbb6355960a98db42e04be47/scripts/docker-write-version.sh#L22

• And the docker build instructions in ReadMe should get updated to include setting this env variable / build arg.

[novocaine]

• Also, the /version that gets written to Docker and is used for update checking uses the Git Tag, not $VERSION.

great spot, indeed this is not consistent with https://github.com/vector-im/element-web/blob/develop/scripts/package.sh#L24 which I had assumed was how things would always be

[novocaine]

#20077 fixes this in a way that restores the previous behaviour, $VERSION will go back to being automatically derived from git

[davidmehren]

Are you going to push a fixed 1.9.6 image to Docker Hub?
I rolled back to 1.9.5 yesterday, as users complained about the upgrade-loop.

[stoically]

Just leaving the keyword !!UNSET!! as text here so it's easier to find.

[cketti]

The docker image tagged v1.9.6 still has this issue.

$ docker run -it --rm vectorim/element-web:v1.9.6 grep -l -R UNSET /app
/app/bundles/9d9a476da9f07ff3c7c0/init.js
/app/bundles/9d9a476da9f07ff3c7c0/vendors~init.js

It seems to be fixed in develop.

$ docker run -it --rm vectorim/element-web:develop grep -l -R UNSET /app | wc -l
0

Image versions:

$ docker images --digests | grep element
vectorim/element-web                  develop           sha256:f186c059b4b15c82fabc4c6f4562e812333ea9e3c46ca312e8b645874a0fac86   b2e2cccb2787   12 hours ago    62.9MB
vectorim/element-web                  v1.9.6            sha256:5b140e4462ff00532df1e19ca9e44e755338001b532c51bcae16b1e7a3415a47   83ca39932c8a   24 hours ago    60MB

[t3chguy]

The fix was done 12h ago, your image is 24h old, so obviously won't contain the fix.

@turt2live is currently working on deploying a new image.

[davidmehren]

The updated image seems to have been pushed. I had to manually run docker pull docker.io/vectorim/element-web:v1.9.6, to get the new image.