Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do we mark messages as authenticated if a room key turns up late (having meanwhile used keyshare or key-restore to grab an unauthenticated key?) #22840

Closed
ara4n opened this issue Jul 13, 2022 · 2 comments
Closed

Do we mark messages as authenticated if a room key turns up late (having meanwhile used keyshare or key-restore to grab an unauthenticated key?) #22840

ara4n opened this issue Jul 13, 2022 · 2 comments
Labels
A-E2EE O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Investigation

Comments

@ara4n
Copy link
Member

ara4n commented Jul 13, 2022

Steps to reproduce

  1. User receives a message whose megolm keys are delayed for some reason
  2. The user now can retrieve the missing megolm key directly from the online backup, meaning they get a "can't authenticate" shield on the message, which is a bit scary.
  3. When the missing authenticated key turns up, do we mark the message as authenticated?

Outcome

What did you expect?

When delayed keys arrive, unauthenticated keys should be replaced the authenticated ones.

What happened instead?

I have a feeling this doesn't happen.

Operating system

No response

Application version

No response

How did you install the app?

No response

Homeserver

No response

Will you send logs?

Yes
@ara4n ara4n added the T-Defect label Jul 13, 2022
@robertlong robertlong added A-E2EE O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist X-Needs-Info This issue is blocked awaiting information from the reporter labels Jul 13, 2022
@dkasak
Copy link
Member

dkasak commented Jul 21, 2022

Possibly related to https://github.com/vector-im/element-web/issues/16318?

@turt2live turt2live added X-Needs-Investigation and removed X-Needs-Info This issue is blocked awaiting information from the reporter labels Jan 10, 2023
@richvdh
Copy link
Member

richvdh commented Apr 3, 2024

Do we mark messages as authenticated if a room key turns up late (having meanwhile used keyshare or key-restore to grab an unauthenticated key?)

In general, no; see #26526.

@richvdh richvdh closed this as completed Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-E2EE O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Investigation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@dkasak @turt2live @ara4n @richvdh @robertlong