"Download video" button will download the content of an HTTP error

[richvdh]

Suppose the media repository is having a bad day, and returning 500 errors; or that the video you are looking for has been removed/was never correctly uploaded.

1. Click the download button on a video:
   
2. Save the file to disk
3. Inspect the file

Observe that the content is, in fact, the body of the HTTP error ({"errcode":"M_NOT_FOUND","error":"Not found"} or similar).

[t3chguy]

Downloads are handled by the browser based on the headers on the resource. Can you confirm what Content-Disposition header this 500 M_NOT_FOUND (shouldn't that be a 404?) contained?

[richvdh]

(shouldn't that be a 404?)

The behaviour is the same whether it is a 404 or 500.

Can you confirm what Content-Disposition header this 500 M_NOT_FOUND (shouldn't that be a 404?) contained?

None, afaict.

[t3chguy]

Turns out this download button does not levy the browser's download mechanics and does load the entire blob into memory and spit it out from there