New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent prepend to riot-web Version Electron/Web #3682

Closed

t3chguy opened this issue Apr 21, 2017 · 0 comments · Fixed by #3683

Member

t3chguy commented Apr 21, 2017 •

edited

Loading

Webapp prepends riot-web version in UserSettings with a v, whereas the Electron App does not

Either https://github.com/vector-im/riot-web/blob/b9ba795cb0b1329520ed4c374b7bd9477b358277/scripts/package.sh#L25 needs changing to omit leading v or the getAppVersion() of ElectronPlatform.js needs changing so that it prepends a v

This is primarily for #1682

The text was updated successfully, but these errors were encountered:

t3chguy mentioned this issue

Remove leading v in /version file, for SemVer and to match Electron ver #3683

Merged

t3chguy closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment