Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

room doesn't stick to bottom shortly after opening it #9018

Closed
bwindels opened this issue Mar 1, 2019 · 4 comments · Fixed by matrix-org/matrix-react-sdk#2746
Closed

room doesn't stick to bottom shortly after opening it #9018

bwindels opened this issue Mar 1, 2019 · 4 comments · Fixed by matrix-org/matrix-react-sdk#2746
Assignees
@bwindels
Labels
A-Timeline P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@bwindels
Copy link
Contributor

bwindels commented Mar 1, 2019

No description provided.

@bwindels bwindels self-assigned this Mar 1, 2019
@turt2live
Copy link
Member

is this #8792 ?

@bwindels
Copy link
Contributor Author

bwindels commented Mar 4, 2019

I suspect it is not, as it only happens when sticking to the bottom, and it has a slight delay when the timeline loads.
Initial investigations seem to point to saveScrollState failing to see we're at the bottom...

@lampholder lampholder added T-Defect P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-Timeline labels Mar 4, 2019
@bwindels
Copy link
Contributor Author

bwindels commented Mar 5, 2019

ok, this does seems to be the flair coming in in the end. It doesn't just make the timeline grow, but also triggers scroll for some reason (scrollTop differencing by 1px). the scroll event is fired before the resizeobserver, unsticking to the bottom because isAtBottom fails.

@bwindels bwindels mentioned this issue Mar 5, 2019
Merged
@jryans
Copy link
Collaborator

jryans commented Mar 5, 2019

Fixed by matrix-org/matrix-react-sdk#2746

@jryans jryans closed this as completed Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bwindels bwindels

Labels
A-Timeline P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent flair pushing timeline downwards matrix-org/matrix-react-sdk
4 participants
@bwindels @jryans @turt2live @lampholder