LockScreen : rework LoggedInFlowNode and Back management #1806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 14, 2023 20:59
…ldren when LockScreen is displayed.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1806 +/- ##
========================================
Coverage 63.37% 63.38%
========================================
Files 1293 1292 -1
Lines 33589 33584 -5
Branches 6979 6974 -5
========================================
Hits 21288 21288
+ Misses 9116 9111 -5
Partials 3185 3185 ☔ View full report in Codecov by Sentry. |
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What the PR solves : previously, when the LockScreen was shown, it was replacing the View of
LoggedInFlowNode, so all the Children.Views were removed from the composition. It was causing troubles with flow like attach files or take and send picture.Why it was done like that : because of how the
BackHandleris managed by Appyx on theBackstack, the children were receiving the onBackPressed from the activity before I could intercept them. So, even if the app was locked it'd pop the backstack instead of putting the app in background.The fix : Do not remove the Children from the composition, but instead block the back management directly in the
MainActivity.