Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the selection in the plain text editor is inside the text bounds #2959

Merged
merged 3 commits into from
May 31, 2024

Conversation

jmartinesp
Copy link
Member

@jmartinesp jmartinesp commented May 31, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Coerce the selection to apply to the text inside the text bounds.

Motivation and context

Fixes a crash seen in the Play Store reports.

Tests

I'm not entirely sure on how to trigger this, to be honest. It happens on the view creation, so those values have to be broken before any user interaction, and that could only happen on state restoration, when coming back from another screen. However, I tried navigating while selecting some text and it worked fine.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 14

Checklist

@jmartinesp jmartinesp requested a review from a team as a code owner May 31, 2024 09:46
@jmartinesp jmartinesp requested review from ganfra and removed request for a team May 31, 2024 09:46
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/eCzu5Z

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.43%. Comparing base (d89004f) to head (87be795).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2959   +/-   ##
========================================
  Coverage    75.43%   75.43%           
========================================
  Files         1547     1547           
  Lines        36845    36847    +2     
  Branches      7139     7139           
========================================
+ Hits         27793    27795    +2     
  Misses        5318     5318           
  Partials      3734     3734           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jmartinesp jmartinesp merged commit 19b6b92 into develop May 31, 2024
21 checks passed
@jmartinesp jmartinesp deleted the fix/jme/plain-text-editor-coerce-selection branch May 31, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants