Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room list filter UI should give you feedback if the all_rooms list is not up-to-date. #1203

Open
ara4n opened this issue Jun 28, 2023 · 6 comments
Labels
A-Room-List A-Room-Search O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Needs-Design X-Needs-Product

Comments

@ara4n
Copy link
Member

ara4n commented Jun 28, 2023

Steps to reproduce

  1. Launch the app after being offline for a while (so SS has expired)
  2. Immediately try to search for a room
  3. Room may not be returned in the room list, because the all_rooms SS list has yet to update.
  4. The user has no idea that the room list search results are incomplete

Therefore, we should show some kind of UI to warn the user if the room list search results are partial, so they know to wait until the all-rooms list has updated - e.g. a spinner row in the results.

Outcome

What did you expect?

To be warned if room list filter results are partial

What happened instead?

No warning; just rooms failed to turn up until i waited a few seconds and tried again.

Your phone model

No response

Operating system version

No response

Application version

257

Homeserver

No response

Will you send logs?

No

@ara4n
Copy link
Member Author

ara4n commented Aug 28, 2023

this isn't that uncommon - it happens for every user every time they foreground the app after being offline for >30 minutes, and will affect any room searches done until all_rooms has synced up again. (With the room cache you'll get stale results returned at least). It will also happen 100% for every user on a fresh login.

@VolkerJunginger
Copy link

We will have a look at the UI feedback for synching with the room-list filters https://github.com/element-hq/element-internal/issues/349

@ara4n
Copy link
Member Author

ara4n commented Oct 3, 2024

this bug still exists, and hasn't been fixed, and still causes problems: for instance, right now, we have anecdotal reports of room search not returning room items. We don't know if this is because the roomlist is stale, or if the app thinks the roomlist is up-to-date and something else has gone wrong.

In other words, we still need some mechanism which tells you, when you search, if it's searching incomplete state or not. The normal idiom would be to put a spinner in the search results to let you know it's showing you an incomplete search result.

@ara4n ara4n reopened this Oct 3, 2024
@ara4n ara4n added O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience A-Room-List and removed O-Uncommon Most users are unlikely to come across this or unexpected workflow A-Sliding-Sync labels Oct 3, 2024
@ara4n
Copy link
Member Author

ara4n commented Oct 28, 2024

I just had a situation where search silently failed to return an older room i knew existed. I ended up waiting about 5 minutes and then trying again, and this time it worked. The lack of UX feedback is 😬

@kongo09
Copy link

kongo09 commented Nov 11, 2024

I just hit the same problem on Android

However, I don't think as a user I would expect feedback that the room list in not up-to-date. This is a technical state that an ordinary user cannot do anything with and wouldn't even understand (what is a room list in the first place?)

The effect shouldn't even exist in such a drastic way. With rooms and the room list being cached, at least the case I've captured in the screen above wouldn't exist. The room I'm searching for is not new, has not a changed name, is frequented by me regularly - there is just no good reason why it wouldn't show. If the app now told me "my room list is incomplete" I'd be even more disappointed as it just feels like broken by desgin.

@ara4n
Copy link
Member Author

ara4n commented Nov 11, 2024

The effect shouldn't even exist in such a drastic way

Agreed, but I believe we're stuck with the current implementation until either persistent event cache lands (roughly end of year) or paginated incremental sync lands in SSS (not even scheduled currently). Instead, for now, the app re-paginates in its roomlist whenever it's been offline for 30 mins - and so for a few seconds after launch it'll not be able to find old rooms in search. So, i maintain that we need to provide a spinner to warn the user to wait a few more seconds if they want reliable search results, for this scenario - even though this scenario will get less frequent in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Room-List A-Room-Search O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Needs-Design X-Needs-Product
Projects
None yet
Development

No branches or pull requests

4 participants