-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Room list filter UI should give you feedback if the all_rooms list is not up-to-date. #1203
Comments
this isn't that uncommon - it happens for every user every time they foreground the app after being offline for >30 minutes, and will affect any room searches done until all_rooms has synced up again. (With the room cache you'll get stale results returned at least). It will also happen 100% for every user on a fresh login. |
We will have a look at the UI feedback for synching with the room-list filters https://github.com/element-hq/element-internal/issues/349 |
this bug still exists, and hasn't been fixed, and still causes problems: for instance, right now, we have anecdotal reports of room search not returning room items. We don't know if this is because the roomlist is stale, or if the app thinks the roomlist is up-to-date and something else has gone wrong. In other words, we still need some mechanism which tells you, when you search, if it's searching incomplete state or not. The normal idiom would be to put a spinner in the search results to let you know it's showing you an incomplete search result. |
I just had a situation where search silently failed to return an older room i knew existed. I ended up waiting about 5 minutes and then trying again, and this time it worked. The lack of UX feedback is 😬 |
Agreed, but I believe we're stuck with the current implementation until either persistent event cache lands (roughly end of year) or paginated incremental sync lands in SSS (not even scheduled currently). Instead, for now, the app re-paginates in its roomlist whenever it's been offline for 30 mins - and so for a few seconds after launch it'll not be able to find old rooms in search. So, i maintain that we need to provide a spinner to warn the user to wait a few more seconds if they want reliable search results, for this scenario - even though this scenario will get less frequent in future. |
Steps to reproduce
Therefore, we should show some kind of UI to warn the user if the room list search results are partial, so they know to wait until the all-rooms list has updated - e.g. a spinner row in the results.
Outcome
What did you expect?
To be warned if room list filter results are partial
What happened instead?
No warning; just rooms failed to turn up until i waited a few seconds and tried again.
Your phone model
No response
Operating system version
No response
Application version
257
Homeserver
No response
Will you send logs?
No
The text was updated successfully, but these errors were encountered: