Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room List Filters Empty State View #2522

Merged
merged 10 commits into from
Mar 5, 2024
Merged

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Mar 4, 2024

fixes #2520

Simulator Screenshot - iPhone 15 - 2024-03-05 at 11 40 41

Copy link

github-actions bot commented Mar 4, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against aba01cb

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 75.43860% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 74.69%. Comparing base (4320e5c) to head (2e921b5).

❗ Current head 2e921b5 differs from pull request most recent head b4901ee. Consider uploading reports for the commit b4901ee to get more accurate results

Files Patch % Lines
...es/Screens/HomeScreen/View/HomeScreenContent.swift 0.00% 14 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2522      +/-   ##
===========================================
- Coverage    75.43%   74.69%   -0.75%     
===========================================
  Files          536      540       +4     
  Lines        37113    37461     +348     
  Branches     17605    17718     +113     
===========================================
- Hits         27997    27980      -17     
- Misses        9116     9264     +148     
- Partials         0      217     +217     
Flag Coverage Δ
unittests 60.64% <75.43%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Velin92 Velin92 marked this pull request as ready for review March 5, 2024 10:32
@Velin92 Velin92 requested a review from a team as a code owner March 5, 2024 10:32
@Velin92 Velin92 requested review from stefanceriu and removed request for a team March 5, 2024 10:32
@Velin92 Velin92 requested a review from pixlwave March 5, 2024 10:41
@Velin92
Copy link
Member Author

Velin92 commented Mar 5, 2024

Regarding the search state while filtering, we are still discussing if we should allow filters to be available/on while searching from a product perspective. Will address this whatever is the product decision in a future PR.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Velin92 Velin92 enabled auto-merge (squash) March 5, 2024 13:44
@Velin92 Velin92 disabled auto-merge March 5, 2024 14:15
@Velin92 Velin92 merged commit 8c68f5a into develop Mar 5, 2024
2 of 3 checks passed
@Velin92 Velin92 deleted the mauroromito/filters_empty_state branch March 5, 2024 14:15
Copy link

sonarqubecloud bot commented Mar 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] [RoomListFilters] Add an empty state to filters
2 participants