-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Room List Filters Empty State View #2522
Conversation
Generated by 🚫 Danger Swift against aba01cb |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2522 +/- ##
===========================================
- Coverage 75.43% 74.69% -0.75%
===========================================
Files 536 540 +4
Lines 37113 37461 +348
Branches 17605 17718 +113
===========================================
- Hits 27997 27980 -17
- Misses 9116 9264 +148
- Partials 0 217 +217
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Regarding the search state while filtering, we are still discussing if we should allow filters to be available/on while searching from a product perspective. Will address this whatever is the product decision in a future PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
ElementX/Sources/Screens/HomeScreen/View/HomeScreenContent.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/HomeScreen/View/HomeScreenContent.swift
Outdated
Show resolved
Hide resolved
|
fixes #2520