Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix translucency of RoomScreen navigation bar. #574

Closed
pixlwave opened this issue Feb 13, 2023 · 1 comment
Closed

Fix translucency of RoomScreen navigation bar. #574

pixlwave opened this issue Feb 13, 2023 · 1 comment
Labels
A-Timeline T-Task Z-BBQ-Beta Required for ElementX - BBQ - Beta Z-Polish

Comments

@pixlwave
Copy link
Member

pixlwave commented Feb 13, 2023

Currently the screen uses a translucent bar but doesn't have any content beneath it. This needs more work as the obvious idea of telling the scrollview to ignore the top safe area reveals some text during the push animation:

Simulator.Screen.Recording.-.iPhone.14.-.2023-02-13.at.16.57.34.mp4

And removing the fixed .toolbarBackground(.visible, for: .navigationBar) modifier on the screen in combination with the ignoring the top safe area results in a completely missing navigation bar:

Simulator.Screen.Recording.-.iPhone.14.-.2023-02-13.at.17.22.47.mp4

The fix may involve messing with which component provides the view's the background colour.

@pixlwave
Copy link
Member Author

Fixed by #1392.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Timeline T-Task Z-BBQ-Beta Required for ElementX - BBQ - Beta Z-Polish
Projects
None yet
Development

No branches or pull requests

2 participants