You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
When somebody uses the reply quote, a link "In reply to" appears in the conversation. Clicking that link goes to the matrix.to URL in the current window/tab instead of opening a new one.
To Reproduce
Steps to reproduce the behavior:
Click on '...' in a message and select "Reply"
Add a reply message and post/send it
Click the "In reply to" link inside your message.
Expected behavior
The hydrogen client is not left to go to the matrix.to url
Screenshots
N/A
Desktop (please complete the following information):
OS: Sailfish OS
Browser sailfishos-browser
Version 78
Smartphone (please complete the following information):
Shouldn't it scroll to the message that was replied to in the existing tab instead of opening in a new tab? Opening a new tab would cause duplicate hydrogen clients to be opened which can cause syncing issues and takes up more RAM.
Yes, that would be the better behaviour indeed. Right now it just navigates to another site 1 then that other site might trigger loading of element or another client [2].
The 1st step is problematic for Sailfish hydrogen packaging because the whole webview app is replaced with matrix.to then the next click might open another client and the current one becomes unusable, and might be a problem for other users too, that's why this would be the shortest solution, to open in a new tab - this also means that the app can detect the new link being clicked and offer to open it in the browser.
To rehash, I would agree that you're describing the best solution, this is just (and the associated PR) a simple workaround.
Describe the bug
When somebody uses the reply quote, a link "In reply to" appears in the conversation. Clicking that link goes to the matrix.to URL in the current window/tab instead of opening a new one.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The hydrogen client is not left to go to the matrix.to url
Screenshots
N/A
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
An easy fix may be hydrogen-sailfishos@f0cfa66
The text was updated successfully, but these errors were encountered: