Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reply links don't open a new tab/window #1157

Closed
b100dian opened this issue Dec 30, 2023 · 2 comments · Fixed by #1158
Closed

Reply links don't open a new tab/window #1157

b100dian opened this issue Dec 30, 2023 · 2 comments · Fixed by #1158

Comments

@b100dian
Copy link

Describe the bug
When somebody uses the reply quote, a link "In reply to" appears in the conversation. Clicking that link goes to the matrix.to URL in the current window/tab instead of opening a new one.

To Reproduce
Steps to reproduce the behavior:

  1. Click on '...' in a message and select "Reply"
  2. Add a reply message and post/send it
  3. Click the "In reply to" link inside your message.

Expected behavior
The hydrogen client is not left to go to the matrix.to url

Screenshots
N/A

Desktop (please complete the following information):

  • OS: Sailfish OS
  • Browser sailfishos-browser
  • Version 78

Smartphone (please complete the following information):

  • Device: Asus Zenfone 8
  • OS: Sailfish OS
  • Browser SailfishOS browser
  • Version 78

Additional context
An easy fix may be hydrogen-sailfishos@f0cfa66

@BurnyBoi
Copy link

Shouldn't it scroll to the message that was replied to in the existing tab instead of opening in a new tab? Opening a new tab would cause duplicate hydrogen clients to be opened which can cause syncing issues and takes up more RAM.

@b100dian
Copy link
Author

Yes, that would be the better behaviour indeed. Right now it just navigates to another site 1 then that other site might trigger loading of element or another client [2].
The 1st step is problematic for Sailfish hydrogen packaging because the whole webview app is replaced with matrix.to then the next click might open another client and the current one becomes unusable, and might be a problem for other users too, that's why this would be the shortest solution, to open in a new tab - this also means that the app can detect the new link being clicked and offer to open it in the browser.
To rehash, I would agree that you're describing the best solution, this is just (and the associated PR) a simple workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants