Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redacting a reaction on an already redacted event makes sync blow up #483

Closed
ptman opened this issue Sep 1, 2021 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@ptman
Copy link

ptman commented Sep 1, 2021

Describe the bug
Error is: Sync failed because of TypeError: target.annotations is undefined
I get the on the top on green background. I can share logs privately.

Desktop (please complete the following information):

  • OS: Linux
  • Browser Firefox
  • Version 91.0.2
  • Hydrogen 0.2.8 (and 0.2.5 had the same problem)
@bwindels bwindels changed the title Sync failed because of TypeError: target.annotations is undefined Redacting a reaction on an already redacted event makes sync blow up Sep 1, 2021
@bwindels
Copy link
Contributor

bwindels commented Sep 1, 2021

Notes from having looked at ptman's logs:

so first the message ($1his...) is redacted
then the reaction to that message ($VRF...)
and it sees that $VRF was a reaction and tries to recalculate the remaining reactions on the target of the reaction ($1his ...) and that fails because the reactions there have already been removed during the prior redaction

@bwindels bwindels added the bug Something isn't working label Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants