Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MSC3912 implementation: Redaction of related events #15687

Open
matrixbot opened this issue Dec 21, 2023 · 0 comments
Open

Update MSC3912 implementation: Redaction of related events #15687

matrixbot opened this issue Dec 21, 2023 · 0 comments

Comments

@matrixbot
Copy link
Collaborator

matrixbot commented Dec 21, 2023

This issue has been migrated from #15687.


Description:

Since MSC3912 has been implemented by matrix-org/synapse#14260, we introduced 2 changes into the MSC for which we need to update this implementation :

  • the new property with_relations has been renamed with_rel_types (to prevent us from introducing a new term ("relations") to refer to event relationships). Only the stable name is changed, we keep the existing unstable one.
  • we introduced a catch-all "*" value, which if found in the list means "any relation type"

There is one stuff missing:
The first Synapse PR (matrix-org/synapse#14260) says:

This implementation is lacking a way to keep watch for incoming events that match the redaction criteria after the redaction request finishes, that'll come in a separate PR.

We have to decide if the backend team can work on this border use case by provided an additional PR. If not, we should remove this part from the MSC (details)

@matrixbot matrixbot changed the title Dummy issue Update MSC3912 implementation: Redaction of related events Dec 22, 2023
@matrixbot matrixbot reopened this Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant