Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix listener docs - admin api only on main process #17590

Merged
merged 3 commits into from
Aug 29, 2024
Merged

fix listener docs - admin api only on main process #17590

merged 3 commits into from
Aug 29, 2024

Conversation

dklimpel
Copy link
Contributor

@dklimpel dklimpel commented Aug 20, 2024 •
edited
Loading

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

Only fix doc.

This was a "drive by change" in 6d47b7e#diff-21eb1b3b6455b7011ccbffc74b0279d87d5c69752d62d0196479b1bbc0bdbee3

@github-actions github-actions bot deployed to PR Documentation Preview August 20, 2024 08:48 Active
@dklimpel dklimpel marked this pull request as ready for review August 20, 2024 08:49
@dklimpel dklimpel requested a review from a team as a code owner August 20, 2024 08:49
@github-actions github-actions bot deployed to PR Documentation Preview August 20, 2024 08:50 Active
anoadragon453
anoadragon453 approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch and very helpful to document.

I've made some small wording changes, but otherwise LGTM!

changelog.d/17590.doc Outdated Show resolved Hide resolved
docs/usage/configuration/config_documentation.md Outdated Show resolved Hide resolved
@anoadragon453 anoadragon453 enabled auto-merge (squash) August 29, 2024 10:24
@github-actions github-actions bot deployed to PR Documentation Preview August 29, 2024 10:25 Active
@anoadragon453 anoadragon453 merged commit 9eed8cd into element-hq:develop Aug 29, 2024
33 checks passed
@dklimpel dklimpel deleted the fix_admin_listener branch August 29, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anoadragon453 anoadragon453 anoadragon453 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dklimpel @anoadragon453