Fix bump stamp for non-joined rooms #17674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should only look for bump stamps in joined rooms, otherwise we should just use the membership stream ordering.
| bump_stamp = new_bump_event_pos.stream | ||
|
|
||
| # Figure out the last bump event in the room if we're in the room. | ||
| if room_membership_for_user_at_to_token.membership == Membership.JOIN: |
There was a problem hiding this comment.
👍 Also have this fixed up in #17658
We can merge this for the new test though ⏩
MadLittleMods
approved these changes
Sep 5, 2024
|
@erikjohnston can you ping me when this is deployed plz? |
|
@ara4n will do, though probably best to wait until monday at this point, unless you desperately want it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should only look for bump stamps in joined rooms, otherwise we should just use the membership stream ordering.