-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sliding Sync: Lazy-loading room members on incremental sync (remember memberships) #17809
Sliding Sync: Lazy-loading room members on incremental sync (remember memberships) #17809
Conversation
Co-authored-by: Eric Eastwood <[email protected]>
# sent it before and send the new state. (if we were tracking | ||
# that we sent any other state, we should still keep track | ||
# that). | ||
{}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's possible that we could remember the specific state_keys
that we have sent down before but this currently just acts the same as if a whole type
was removed (same as simple_remove_type
)
This is just a performance optimization though and the result would look like following:
{}, | |
{ | |
EventTypes.Member: { | |
"@user3:test", | |
} | |
}, |
Perhaps it's good that we "garbage collect" and forget what we've sent before for a given type
when the client stops caring about a certain type
🤷.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense! I am slightly worried about the increase in the size of the tables if we keep adding more and more members in there, but I'll have a little think about how we might make that more efficient.
…c-lazy-load-members-on-incrental-sync3 Conflicts: synapse/handlers/sliding_sync/__init__.py
…ers-on-incrental-sync3 Conflicts: synapse/handlers/sliding_sync/__init__.py tests/handlers/test_sliding_sync.py
…ers-on-incrental-sync3
…ers-on-incrental-sync3
Co-authored-by: Erik Johnston <[email protected]>
…ers-on-incrental-sync3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Woot! Thanks for the review @erikjohnston 🦎 |
Lazy-loading room members on incremental sync and remember which memberships we've sent down the connection before (up-to 100)
Fix #17804
Follow-up/alternative to #17806
Depends on #17785
Pull Request Checklist
EventStore
toEventWorkerStore
.".code blocks
.(run the linters)