Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix internal server error when updating 3pid address with invalid email #18125

Merged
merged 3 commits into from
Feb 12, 2025

Conversation

qashlan
Copy link
Contributor

@qashlan qashlan commented Feb 3, 2025

When updating 3pid for a user email from admin api and sending invalid email the server throws 500 internal server error.
changed to 400 Bad request and returned the error message

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

@qashlan qashlan force-pushed the 5xx-on-canonicalise-email branch from dee14f8 to 50831df Compare February 3, 2025 00:57
Signed-off-by: qashlan <[email protected]>
Signed-off-by: Ahmed Qashlan <[email protected]>
@qashlan qashlan force-pushed the 5xx-on-canonicalise-email branch from 50831df to 8a6c1af Compare February 3, 2025 00:58
Signed-off-by: qashlan <[email protected]>
Signed-off-by: Ahmed Qashlan <[email protected]>
@qashlan qashlan marked this pull request as ready for review February 3, 2025 00:59
@qashlan qashlan requested a review from a team as a code owner February 3, 2025 00:59
@qashlan qashlan changed the title updating 3pid with invalid email causes internal server error Fix internal server error when updating 3pid address with invalid email Feb 3, 2025
Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@erikjohnston erikjohnston enabled auto-merge (squash) February 12, 2025 13:26
@erikjohnston erikjohnston merged commit 816054b into element-hq:develop Feb 12, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants