Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to proxy outbound requests from Synapse in tests #18158

Merged
merged 7 commits into from
Feb 17, 2025

Conversation

MadLittleMods
Copy link
Contributor

@MadLittleMods MadLittleMods commented Feb 13, 2025

Add support to proxy outbound requests from Synapse in tests. Adds new environment variables that can be used with the Docker image (SYNAPSE_HTTP_PROXY/SYNAPSE_HTTPS_PROXY/SYNAPSE_NO_PROXY)

Useful for things like the Secure Border Gateway

Why is this necessary?

You can already configure the HTTP_PROXY/HTTPS_PROXY environment variables to proxy outbound requests but setting this globally in the Docker image affects all processes which isn't always desirable or workable in the case where the proxy is running in the Docker image itself (because the Debian packages will fail to download because the proxy isn't up and running yet) . Adding Synapse specific environment variables (SYNAPSE_HTTP_PROXY/SYNAPSE_HTTPS_PROXY/SYNAPSE_NO_PROXY) makes things much more targetable.

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

@MadLittleMods MadLittleMods marked this pull request as ready for review February 13, 2025 23:28
@MadLittleMods MadLittleMods requested a review from a team as a code owner February 13, 2025 23:28
@MadLittleMods MadLittleMods merged commit 12dc6b1 into develop Feb 17, 2025
39 checks passed
@MadLittleMods MadLittleMods deleted the madlittlemods/proxy-outbound-in-tests branch February 17, 2025 16:23
@MadLittleMods
Copy link
Contributor Author

Thanks for the review @erikjohnston 🦞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants