Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ModuleApi: Should threepid properties validate_at and added_at be 0? #7699

Open
matrixbot opened this issue Dec 17, 2023 · 0 comments
Open

ModuleApi: Should threepid properties validate_at and added_at be 0? #7699

matrixbot opened this issue Dec 17, 2023 · 0 comments
Labels
T-Other z-p3

Comments

@matrixbot
Copy link
Collaborator

matrixbot commented Dec 17, 2023 •
edited
Loading

This issue has been migrated from #7699.

This was spun out of matrix-org/synapse#7684

When ModuleApi.register() has emails= set to some emails, those emails are created and added to the new user's account.

However, in the database validated_at and added_at are set to 0, which some other may misinterpret.

Is this intentional or an oversight?

I've at least added the behaviour to a test here: https://github.com/matrix-org/synapse/pull/7684/files#diff-f7ba2d6448431a208d9b515b904ed854R49-R50 Which should be updated as part of closing this issue.
@matrixbot matrixbot changed the title Dummy issue ModuleApi: Should threepid properties validate_at and added_at be 0? Dec 21, 2023
@matrixbot matrixbot reopened this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-Other z-p3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@matrixbot