Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synapse allows invalid characters in the signature key id #8307

Open
matrixbot opened this issue Dec 18, 2023 · 0 comments
Open

Synapse allows invalid characters in the signature key id #8307

matrixbot opened this issue Dec 18, 2023 · 0 comments

Comments

@matrixbot
Copy link
Collaborator

matrixbot commented Dec 18, 2023

This issue has been migrated from #8307.


Synapse seems to accept more characters in the signature key id than the spec allows (for example +).

In Matrix HQ there's an event with signatures like this:

        "signatures": {
            "solver.nu": {
                "ed25519:i+b2": "eodPQHXrns8Jk0XITTlaB61XdjxJW8uCi7paKqgrJmA5ok0NfsRw4Zhyx9RaIs/e7tZMJ29O46oh0IRx6jwZCQ"
            }
        }

But the spec says only [a-zA-Z0-9_] is allowed (https://matrix.org/docs/spec/server_server/r0.1.4#post-matrix-key-v2-query)

@matrixbot matrixbot changed the title Dummy issue Synapse allows invalid characters in the signature key id Dec 21, 2023
@matrixbot matrixbot reopened this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant