Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce that AppData URLs have a protocol #14

Open
cassidyjames opened this issue Jan 7, 2018 · 2 comments
Open

Enforce that AppData URLs have a protocol #14

cassidyjames opened this issue Jan 7, 2018 · 2 comments

Comments

@cassidyjames
Copy link
Contributor

Right now AppData URLs (i.e. issue tracker, homepage, translations) can be inserted without protocols; see heisantosh/qrshare#22. This means they aren't actually usable inside of AppCenter. We should enforce the inclusion of protocols with a test in Houston.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
@cassidyjames
Copy link
Contributor Author

We were hit again by an issue that broke builds in appcenter-web: elementary/appcenter-web@5211529#diff-bb395e7f937561bf67ebfcd89b29dd89R7

@btkostner
Copy link
Contributor

To be clear, that was not an issue with a protocol, but urls that point to files that don't exist.

@danirabbit danirabbit transferred this issue from elementary/houston May 11, 2021
@danirabbit danirabbit transferred this issue from elementary/appcenter-dashboard May 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cassidyjames @btkostner