Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate integer prices #18

Open
cassidyjames opened this issue Jun 28, 2018 — with Slack · 2 comments
Open

Validate integer prices #18

cassidyjames opened this issue Jun 28, 2018 — with Slack · 2 comments

Comments

Copy link
Contributor

The AppCenter client only supports prices in integer dollars (by design). However, some apps have non-integer prices: https://github.com/kjlaw89/archetype

AppCenter currently just takes the int and lops off the decimal, which is probably not what a developer would expect. We should validate this in the AppData at build time so the devs aren't setting unexpected prices.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@lewisgoddard
Copy link
Member

Here is probably a good place for me to ask: Why whole integer dollars only? Why not just anything over a minimum of $1?

@cassidyjames
Copy link
Contributor Author

@lewisgoddard mostly because of how the UI is designed (it's a lot nicer to say, "Install Foo for $3" than to always have to do "Install Foo for $3.00"). I'd be open to changing it, but right now AppCenter expects whole dollars by design, and Houston doesn't do anything to enforce that.

@danirabbit danirabbit transferred this issue from elementary/houston May 11, 2021
@danirabbit danirabbit transferred this issue from elementary/appcenter-dashboard May 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants