-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add org.godotengine.godot.BaseApp 4.3 in appcenter repo #542
Comments
This should be possible in theory if we built some GitHub actions somewhere to either sync these from Flathub to our remote, or build them from source and then push them. But, I've decided to put this on hold for now since it seems there's a few comments in issues on the Flathub repos that suggest that using the BaseApp might not be the best option. [1] [2] It sounds like the biggest issue is that even patch releases of Godot may not be compatible with .pck files built by other patch releases. So for example, you could build your .pck file with 4.3.0, use the It increases build times, but it seems like a much better idea to build the specific version of Godot you want to use in your Flatpak manifest, use that to build your .pck file and then ship that version of Godot and the built .pck file together to ensure compatibility. You now have 2 PRs on your repo to choose from to achieve this because @cassidyjames was working on it at the same time as me 😆 |
Aaa, I see. Thanks a lot to you both for helping me with this. But yeah the concern regarding the various point releases of Godot being incompatible with pck files is a real issue. |
Is this still relevant? I think we went another direction for publishing Godot games no? |
Yes, I will close this. The current solution works. |
Problem
This is for adding Sanctify in AppCenter. This requires org.godotengine.godot.BaseApp 4.3 (which is also available on the Flathub repo). Without that the game can't be built in the flatpak pipeline using appcenter repo.
Proposal
Keeping major versions of Godot base app (latest stable being 4.3) in the repo will help release and maintain godot games on AppCenter.
Prior Art (Optional)
Flathub Repo has this base app support.
The text was updated successfully, but these errors were encountered: