Review workflow is failing with "Create Artifact Container failed" error

[ryonakano]

What Happened?

From #548 (comment)

The Review workflow is failing with the following error:

Error: Build failed: Error: Create Artifact Container failed: The artifact name com.github.ztefn.haguichi-x86_64 is not valid. Request URL https://pipelinesghubeus24.actions.githubusercontent.com/27kOXcXbm09kHxrFJEHB25mTfYcOg8anCtwtGzd2PXJ79lMxKT/_apis/pipelines/workflows/13082823958/artifacts?api-version=6.0-preview

Steps to Reproduce

1. Go to the app submission PRs like Create io.elementary.goaltracker.json #545 or Update com.github.ztefn.haguichi to 1.151.0 #548
2. See the build log of the CI

Expected Behavior

The workflow should success

OS Version

8.x (Circe)

Session Type

Classic Session (X11, This is the default)

Software Version

Latest release (I have run all updates)

Log Output

/usr/bin/flatpak build-bundle repo com.github.ztefn.haguichi.flatpak --runtime-repo=https://flatpak.elementary.io/repo.flatpakrepo --arch=x86_64 com.github.ztefn.haguichi stable
Uploading artifact...
Starting artifact upload
For more detailed logs during the artifact upload process, enable step-debugging: https://docs.github.com/actions/monitoring-and-troubleshooting-workflows/enabling-debug-logging#enabling-step-debug-logging
Artifact name is valid!
Create Artifact Container - Error is not retryable
##### Begin Diagnostic HTTP information #####
Status Code: 400
Status Message: Bad Request
Header Information: {
  "content-length": "268",
  "content-type": "application/json; charset=utf-8",
  "date": "Sat, 01 Feb 2025 04:47:09 GMT",
  "server": "Kestrel",
  "cache-control": "no-store,no-cache",
  "pragma": "no-cache",
  "strict-transport-security": "max-age=2592000",
  "x-tfs-processid": "15ed339a-69cd-4cae-8260-db3e247bdd6d",
  "activityid": "eca2c705-0873-4ba9-82a1-000b6a50538d",
  "x-tfs-session": "eca2c705-0873-4ba9-82a1-000b6a50538d",
  "x-vss-e2eid": "eca2c705-0873-4ba9-82a1-000b6a50538d",
  "x-vss-senderdeploymentid": "2c974d96-2c30-cef5-eff2-3e0511a903a5",
  "x-frame-options": "SAMEORIGIN"
}
###### End Diagnostic HTTP information ######
##### Begin Diagnostic HTTP information #####
Status Code: 400
Status Message: Bad Request
Header Information: {
  "content-length": "268",
  "content-type": "application/json; charset=utf-8",
  "date": "Sat, 01 Feb 2025 04:47:09 GMT",
  "server": "Kestrel",
  "cache-control": "no-store,no-cache",
  "pragma": "no-cache",
  "strict-transport-security": "max-age=2592000",
  "x-tfs-processid": "15ed339a-69cd-4cae-8260-db3e247bdd6d",
  "activityid": "eca2c705-0873-4ba9-82a1-000b6a50538d",
  "x-tfs-session": "eca2c705-0873-4ba9-82a1-000b6a50538d",
  "x-vss-e2eid": "eca2c705-0873-4ba9-82a1-000b6a50538d",
  "x-vss-senderdeploymentid": "2c974d96-2c30-cef5-eff2-3e0511a903a5",
  "x-frame-options": "SAMEORIGIN"
}
###### End Diagnostic HTTP information ######
Error: Build failed: Error: Create Artifact Container failed: The artifact name com.github.ztefn.haguichi-x86_64 is not valid. Request URL https://pipelinesghubeus24.actions.githubusercontent.com/27kOXcXbm09kHxrFJEHB25mTfYcOg8anCtwtGzd2PXJ79lMxKT/_apis/pipelines/workflows/13082823958/artifacts?api-version=6.0-preview

Hardware Info

Not relevant

[danirabbit]

Fails in the publish action too https://github.com/elementary/appcenter-reviews/actions/runs/13123129312/job/36613553405

[danirabbit]

This appears to be happening for all flatpak actions. So I wonder if it's a Github Actions/Flatpak Builder issue

[ryonakano]

Ah yes, many people who use flatpak-builder reports the same issue: flatpak/flatpak-github-actions#214

[ryonakano]

flatpak/flatpak-github-actions#215 seems to fix the above issue, so let's wait it get reviewed and merged by Flatpak maintainers, and then update flat-manager version we use in our workflow as before:

appcenter-reviews/.github/workflows/publish.yml

Line 83 in ba04b4f

uses: flatpak/flatpak-github-actions/flat-manager@0ab9dd6a6afa6fe7e292db0325171660bf5b6fdf # v6.3 plus https://github.com/flatpak/flatpak-github-actions/pull/160

[ryonakano]

Upstream fixed in flatpak/flatpak-github-actions#217

[danirabbit]

Hrm. Reopening because the workflow is still failing

[ryonakano]

Retrying the build seems like checkout to the revision when it's committed, which means flat-manager v6.4 is not used.

From https://github.com/elementary/appcenter-reviews/actions/runs/13123129312/job/37464633071:

Run flatpak/flatpak-github-actions/[email protected]
  with:
    bundle: com.github.ztefn.haguichi.flatpak
    manifest-path: com.github.ztefn.haguichi.json
    run-tests: false
    repository-name: appcenter
    repository-url: https://flatpak.elementary.io/repo.flatpakrepo
    branch: stable
    cache-key: flatpak-builder-ba04b4f69c3509e8490e245526c80b8b6d1e5ddd
    arch: x86_64
    build-bundle: true
    cache: true
    restore-cache: true
    verbose: false
/usr/bin/docker exec  676f64809995dd82cf6f1cabdaab781a808bc4e253333f043552771144a10c4f sh -c "cat /etc/*release | grep ^ID"
/usr/bin/flatpak remote-add --if-not-exists appcenter https://flatpak.elementary.io/repo.flatpakrepo

So maybe we need a force re-trigger like 3640b5e unfortunately 😞

[ztefn]

I created a new pull request (#552) for you to trigger the workflow.

[danirabbit]

Looks like the publish workflow succeeded! Thanks both of you :)