Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Strip Trailing Space from the Extensions tab to Behavior or Interface #1098

Closed
mks-h opened this issue Sep 6, 2021 · 6 comments · Fixed by #1151
Closed

Move Strip Trailing Space from the Extensions tab to Behavior or Interface #1098

mks-h opened this issue Sep 6, 2021 · 6 comments · Fixed by #1151
Labels
Needs Design Waiting for input from the UX team

Comments

@mks-h
Copy link

mks-h commented Sep 6, 2021

Problem

The so-called extensions are not really extensions but just checkboxes for a particular feature.

Proposal

They better be proper switches in Behavior or Interface tabs.

@mks-h mks-h changed the title Integrate extensions to settings Move functionality from the Extensions tab to Behavior or Interface Sep 6, 2021
@jeremypw
Copy link
Collaborator

jeremypw commented Sep 6, 2021

They are extensions inasmuchas they are provided by separate modules through a plugin architecture, not by the main codebase. So, in theory at least, there could be third-party plugins in the list.

@jeremypw
Copy link
Collaborator

jeremypw commented Sep 6, 2021

I agree that some extension functionality like "Preserve Indent" could be absorbed into the main code base as settings.

@jeremypw jeremypw added the Needs Design Waiting for input from the UX team label Sep 6, 2021
@igordsm
Copy link
Contributor

igordsm commented Sep 17, 2021

I'm working on a Snippet functionality and having "Preserve Indent" (and its functions) in the main code base would be very convenient. Some of the code would be useful when inserting snippets with multiple lines. @jeremypw I could work on this refactoring, is it desirable?

@jeremypw
Copy link
Collaborator

@igordsm Its 👍 from me. Maybe best to raise a specific issue first to get wider feedback in case there is a drawback I am not aware of.

@Marukesu
Copy link
Contributor

I'm working in add support for the rest of the editorconfig spec, and it would be good to have "Strip trailing whitespace" as part of code itself.

@jeremypw
Copy link
Collaborator

jeremypw commented Dec 8, 2021

I am going to focus this issue on "Strip Trailing Spaces". Please open new issues for each extension to be moved into the main code so they can be addressed one at a time.

@jeremypw jeremypw changed the title Move functionality from the Extensions tab to Behavior or Interface Move Strip Trailing Space from the Extensions tab to Behavior or Interface Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Waiting for input from the UX team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants