From 114253fbacac91ad5c2095139d06bc4df93c9fe0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Danielle=20For=C3=A9?= Date: Thu, 11 Nov 2021 03:11:57 -0800 Subject: [PATCH] Update prepare-code-for-review.md (#8) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Update prepare-code-for-review.md * Update development/prepare-code-for-review.md Co-authored-by: Corentin Noël * Update prepare-code-for-review.md Co-authored-by: Corentin Noël --- development/prepare-code-for-review.md | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/development/prepare-code-for-review.md b/development/prepare-code-for-review.md index 9c20781..38b614e 100644 --- a/development/prepare-code-for-review.md +++ b/development/prepare-code-for-review.md @@ -12,7 +12,13 @@ If it's not obvious, it can also be helpful to include instructions on how to te ## Review Your Own Branch -When you have your initial version for the proposed change working, look at your changes once again and ask yourself if anything could be improved before marking it "Ready for Review". +When you have your initial version for the proposed change working, look at your changes once again and ask yourself if anything could be improved before marking it "Ready for Review". Be sure to check that: + +✅️ Your branch adheres to the elementary [code style guide](https://docs.elementary.io/develop/writing-apps/code-style) + +✅️ No New Terminal warnings are introduced + +✅️ Your branch passes required [status checks](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/about-status-checks) {% hint style="info" %} If you need help or your branch isn't quite ready for review, you can open a Draft pull request and convert it to "Ready for Review" later