-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[odin beta] No terminal bell any more #596
Comments
There is a setting |
It could be argued that since it is supported, this setting should be exposed in the UI. |
A complication of this is that the settings |
@danirabbit Think more on it, is it necessary to have a separate setting for audible bell in Terminal? We can already control this globally in in System Settings/Sound. |
@jeremypw i remember we added a separate option here because the bell sound was particularly obnoxious in terminal for some reason. I don't remember the specifics, it's worth looking at again probably since it's been years |
@danirabbit OK, I'll leave the PR up for review then. To keep it simple, it does not try to reflect the state of other settings - the text just notes "subject to system settings". |
What Happened
I ran ping -a in the new odin terminal and there was no sound
Expected Behavior
The terminal bell should be heard to indicate that the server is up (it sends the bell character).
If the bell is disabled by default, a toggle to turn it back on would be nice
Steps to Reproduce
Logs
Platform Information
The text was updated successfully, but these errors were encountered: