Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type Support For L.Curve? #38

Closed
ardeora opened this issue Apr 27, 2021 · 6 comments
Closed

Type Support For L.Curve? #38

ardeora opened this issue Apr 27, 2021 · 6 comments

Comments

@ardeora
Copy link
Contributor

ardeora commented Apr 27, 2021

Hello there! I hope you are had an amazing weekend. I have been using your leaflet plugin since a while and am absolutely grateful for it. I was wondering if you would be interested in adding type support for this plugin? I am willing to create a TypeScript declaration file for this extension 😃 Hope you have a wonderful week!

@elfalem
Copy link
Owner

elfalem commented Apr 27, 2021

Hello @ardeora! I'm glad you found the Leaflet.curve plugin to be useful. It would be a welcome addition to have type support. I would appreciate a PR for the TypeScript declaration file.

@ardeora
Copy link
Contributor Author

ardeora commented Apr 27, 2021

Okay awesome! I'll open a pull request soon 🥳

@ardeora
Copy link
Contributor Author

ardeora commented May 2, 2021

#39 I have made a pull request. Please let me know if you would like some changes to be made. I would be happy to update them!

@elfalem
Copy link
Owner

elfalem commented May 4, 2021

Thank you @ardeora! The pull request looks good to me. I will merge and make a new release when I get a chance.

@ardeora
Copy link
Contributor Author

ardeora commented May 4, 2021

Awesome! Thanks. Let me know if you need help with anything else :D

@elfalem
Copy link
Owner

elfalem commented May 8, 2021

version 0.8.0 has been published. Thanks again for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants