Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize using ExtendedTime rather than base time in all API functions #37

Open
elidupree opened this issue Aug 30, 2017 · 2 comments

Comments

@elidupree
Copy link
Owner

elidupree commented Aug 30, 2017

I've been steadily exposing ExtendedTime more and more, and at this point, there's no reason not to go the rest of the way.

This applies to snapshot_before(), valid_since(), updated_until_before(), and forget_before().

This is mostly just an elegance thing, but it may be useful to allow snapshots of unusual ExtendedTimes for debug-examining stuff.

insert_fiat_event() could still use base time + id, because it's similar to the interface for creating predictions, and it supports automatically protecting the user from colliding fiat event ids with prediction ids.

The main downside of this change is that it would obligate the user to call beginning_of() themselves, but that seems tolerable.

@elidupree
Copy link
Owner Author

Correction: valid_since() defines the times when it's legal to create fiat events, which can only be in increments of base time. However, it still makes sense for the snapshot function, updated_until_before(), and forget_before() to support ExtendedTime.

Also, the snapshot function wouldn't be called snapshot_before() anymore, but rather just snapshot().

@elidupree
Copy link
Owner Author

My latest version of the design has eliminated the iteration concept and the ExtendedTime type.

The question remains of whether mid-instant snapshots make sense. They are certainly a confusing concept, so I'm inclined to say that even if they exist, they are a separate function from snapshot_before().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant