Skip to content
This repository has been archived by the owner on Jun 6, 2022. It is now read-only.

possibility to disable using custom hostannotation #9

Open
zetaab opened this issue Sep 21, 2018 · 0 comments
Open

possibility to disable using custom hostannotation #9

zetaab opened this issue Sep 21, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@zetaab
Copy link
Contributor

zetaab commented Sep 21, 2018

currently there is feature to define custom hostannotation https://github.com/ElisaOyj/openshift-lb-controller/blob/master/pkg/controller/controller.go#L39 However, this is not good thing if you have two separate lb-controllers in same openshift cluster. Lets say that we have two different lb-controllers, first one is taking care of external.company.com and second one internal.company.com. Now if we have this custom hostannotation defined in both, the lb-controller does not know where to expose this custom host. Currently it will expose that to both, and it is security issue if used like this.

@zetaab zetaab changed the title possibility to disable using customhostannotation possibility to disable using custom hostannotation Sep 21, 2018
@zetaab zetaab added the enhancement New feature or request label Sep 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant