This repository has been archived by the owner on Oct 8, 2020. It is now read-only.
Xgit.Repository.WorkingTree.read_tree/3 could infinite loop on a malformed tree. #178
Open
3 tasks done
Labels
bug
Something isn't working
help wanted
Extra attention is needed
TO DO
Fix an incomplete implementation
TO DO
commentDescribe What Is Incomplete
The function
Xgit.Repository.WorkingTree.read_tree/3
could go into an infinite loop if asked to read a malformed tree. The tree would need to point to itself or to one of its descendants. There is currently no protection against this.Definition of Done
Construct a malformed tree (i.e. has a reference cycle). Call
Xgit.Repository.WorkingTree.read_tree/3
withobject_id
set to that tree. A suitable error code should be returned rather than a timeout or stack-depth error.The text was updated successfully, but these errors were encountered: