Skip to content
This repository has been archived by the owner on Oct 8, 2020. It is now read-only.

Xgit.Repository.WorkingTree.read_tree/3 could infinite loop on a malformed tree. #178

Open
3 tasks done
scouten opened this issue Sep 26, 2019 · 0 comments
Open
3 tasks done
Labels
bug Something isn't working help wanted Extra attention is needed TO DO Fix an incomplete implementation

Comments

@scouten
Copy link
Collaborator

scouten commented Sep 26, 2019

  • Add label: "TO DO"
  • Add label: "good first issue" or "help wanted" if appropriate
  • Add link to this issue in a comment near the TO DO comment

Describe What Is Incomplete
The function Xgit.Repository.WorkingTree.read_tree/3 could go into an infinite loop if asked to read a malformed tree. The tree would need to point to itself or to one of its descendants. There is currently no protection against this.

Definition of Done
Construct a malformed tree (i.e. has a reference cycle). Call Xgit.Repository.WorkingTree.read_tree/3 with object_id set to that tree. A suitable error code should be returned rather than a timeout or stack-depth error.

@scouten scouten added bug Something isn't working help wanted Extra attention is needed TO DO Fix an incomplete implementation labels Sep 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working help wanted Extra attention is needed TO DO Fix an incomplete implementation
Projects
None yet
Development

No branches or pull requests

1 participant