Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand Support for Non-OpenAI Models in Token Trimming #1565

Closed
monilpat opened this issue Dec 29, 2024 · 3 comments
Closed

Expand Support for Non-OpenAI Models in Token Trimming #1565

monilpat opened this issue Dec 29, 2024 · 3 comments
Labels

Comments

@monilpat
Copy link
Collaborator

Feature Request

Is your feature request related to a problem? Please describe.

Currently, the system is limited to using TiktokenModel for token trimming, which restricts compatibility with non-OpenAI models. This limitation may hinder the integration of diverse models that could enhance performance and scalability.

Describe the solution you'd like

Implement a flexible token trimming mechanism that supports a variety of models beyond TiktokenModel. This could involve abstracting the token trimming logic to accommodate different model architectures and tokenization strategies.

Describe alternatives you've considered

Continuing with the current model-specific approach, but this would limit the flexibility and potential for optimization across different models.

Additional context

Expanding support for non-OpenAI models will improve the system's adaptability and allow for better optimization of token trimming processes. This aligns with the goal of enhancing algorithm efficiency and scalability.

Related Issues

None at the moment, but tracking this enhancement will facilitate discussions around implementation strategies.

@tcm390
Copy link
Collaborator

tcm390 commented Dec 31, 2024

related: #1439

@tcm390
Copy link
Collaborator

tcm390 commented Dec 31, 2024

@monilpat please kindly try the PR and see if it fixes your issue. #1605

@shakkernerd
Copy link
Member

Implemented in #1605

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants