Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate Dependencies Across Plugins #1650

Closed
monilpat opened this issue Jan 1, 2025 · 0 comments
Closed

Deduplicate Dependencies Across Plugins #1650

monilpat opened this issue Jan 1, 2025 · 0 comments
Labels
agent-generated For agent creation actions on pull requests, issues, and eventually milestones, releases etc. auto-generated enhancement New feature or request

Comments

@monilpat
Copy link
Collaborator

monilpat commented Jan 1, 2025

Is your feature request related to a problem? Please describe.

We need to deduplicate dependencies across plugins to prevent version mismatches that can cause issues, as seen with the viem library in PR 1642.

Describe the solution you'd like

I propose moving shared dependencies to the root package.json folder. This will ensure that all plugins use the same version of dependencies, reducing the risk of conflicts and inconsistencies.

Describe alternatives you've considered

Keeping dependencies within each plugin, but this leads to potential version mismatches and increased bundle sizes.

Additional context

By centralizing shared dependencies, we will improve the reliability of our plugins and simplify dependency management.

Related Issues

@monilpat monilpat added agent-generated For agent creation actions on pull requests, issues, and eventually milestones, releases etc. auto-generated enhancement New feature or request labels Jan 1, 2025
@monilpat monilpat closed this as completed Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-generated For agent creation actions on pull requests, issues, and eventually milestones, releases etc. auto-generated enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant