Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core Unit Tests #340

Closed
ponderingdemocritus opened this issue Nov 15, 2024 · 6 comments
Closed

Core Unit Tests #340

ponderingdemocritus opened this issue Nov 15, 2024 · 6 comments
Labels
enhancement New feature or request testing

Comments

@ponderingdemocritus
Copy link
Contributor

This task is to implement unit tests for all the core functions.

Use Vitest as the test suite.

@ponderingdemocritus ponderingdemocritus added testing enhancement New feature or request labels Nov 15, 2024
@normand1
Copy link
Contributor

@ponderingdemocritus Are the existing tests passing now or is this task for new tests? I've tried running tests on main and not able to get them all to pass. Also, do you know if there are tests running in CI now? I haven't found anywhere we're doing this yet.

@odilitime
Copy link
Collaborator

Last I checked the tests are not passing

@normand1
Copy link
Contributor

Also,

Use Vitest as the test suite.

I don't see Vitest as a current Core dependency. Looks like all tests are written in Jest. Is there another task to implement Vitest?

@ponderingdemocritus
Copy link
Contributor Author

there are no real Unit tests in the repo. The current e2e tests are broken and need overhauling.

First step however is to implement unit tests.

If you want to tackle this:

  • install vite
  • implement a unit test for one of the files in the core (eg actions)

@normand1
Copy link
Contributor

@ponderingdemocritus There were actually a lot of tests and test resources that appear to only have been added a couple of weeks ago and they were all just deleted by this PR:
https://github.com/ai16z/eliza/pull/287/files#diff-c692db8dc3c120023e07a56db7bd030a714772dfb75b1006c3e479c866d9f7c2

@normand1
Copy link
Contributor

@ponderingdemocritus removed jest in favor of vitest as discussed and re-implemented one of the deleted tests as a starting point in this PR:
#365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request testing
Projects
None yet
Development

No branches or pull requests

3 participants