-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apply check_max_size logic to headers as well #65
Labels
Comments
Example of a failing test (in elixir) test "fails on large headers" do
cookie = "bar=" <> String.duplicate("a", 10_000_000) # 10 MB binary
response = request(:get, "/headers", [{"cookie", cookie}]) # GET request with cookie header bar=aaaaa...
assert match?({400, _, _}, response) or match?({:error, :closed}, response) # elli returns 200, consumes all headers
assert {200, _, _} = request(:get, "/headers", [{"foo", "bar"}, {"baz", "bat"}])
end |
Possibly applies to the request line ( GET /aaaaaaa[... and 10MB more of aaaaa] HTTP/1.1 |
Looks like a bug to me. Thanks for pointing it out. PRs are most welcome! |
Great! I'll try to make one today. |
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now it's possible to "load" the socket with large headers, so I don't think there are any checks for this scenario (other than headers count < 100).
The text was updated successfully, but these errors were encountered: