Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow TOTP configuration options #6

Open
elliot-sawyer opened this issue May 30, 2018 · 2 comments
Open

Allow TOTP configuration options #6

elliot-sawyer opened this issue May 30, 2018 · 2 comments

Comments

@elliot-sawyer
Copy link
Owner

Certain aspects of the QR code and the authenticator should be configurable by the developer or CMS admin. This list includes:

  • length of token (currently defaults to 6)
  • Allow freshly expired or upcoming tokens to authenticate, currently not allowed. If the server time or user's time are not exactly synced, validation may fail.
  • Some authenticator apps support changing the TOTP algorithm, for SHA1 (default), SHA256, and SHA512. Google Authenticator ignores this, but others may support it.
  • Configurable counter and period. Google Authenticator ignores this, but others may support it.
  • issuer and label currently defaults to SiteConfig.Title. This is ideally configureable by a CMS admin or via developer config. SiteConfig.Title should be the fallback
  • extension hooks:
    • TOTPForm::getFormFields
    • TOTPForm::getFormActions
    • TOTPAuthenticator::validateTOTP
    • TOTPLoginHandler::validateTOTP

Other suggestions welcome in the comments

@elliot-sawyer
Copy link
Owner Author

PR for algorithm adjustment: #10

@robbieaverill
Copy link
Collaborator

Labelled as impact/high because configurability is very important for this before stable release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants