ActivityExecutionContext.Children collection is not populated

[bobhauser]

Description

The ActivityExecutionContext has a property called Children. The intention is that when the ParentActivityExecutionContext property is set on an ActivityExecutionContext the current context is added to its parent's Children set. See:

elsa-core/src/modules/Elsa.Workflows.Core/Contexts/ActivityExecutionContext.cs

Line 101 in 2c394e2

_parentActivityExecutionContext?.Children.Add(this);

That property is not, however, used to set the parent ActivityExecutionContext. Instead the _parentActivityExecutionContext is assigned to directly here

elsa-core/src/modules/Elsa.Workflows.Core/Contexts/ActivityExecutionContext.cs

Line 47 in 2c394e2

_parentActivityExecutionContext = parentActivityExecutionContext;

The result of this is that the ActivityExecutionContext.Children set is always empty, and functionality that depends on it does not work as expected. One example of this can be found in Flowchart.HasPendingWork.

[sfmskywalker]

Great catch. Thanks for the PR!