Skip to content
This repository has been archived by the owner on Dec 10, 2024. It is now read-only.

Remove ember-cli-test-loader from bower.json #122

Closed
nucleartide opened this issue Aug 11, 2016 · 3 comments
Closed

Remove ember-cli-test-loader from bower.json #122

nucleartide opened this issue Aug 11, 2016 · 3 comments

Comments

@nucleartide
Copy link

I'm on Ember 2.7, and I get a deprecation warning after installing ember-cli-mocha:

DEPRECATION: ember-cli-test-loader should now be included as an NPM module with version 1.1.0 or greater.

It'd be nice to remove this line, but I'm not sure how that might affect people using versions of Ember prior to 2.7.

@Turbo87
Copy link
Member

Turbo87 commented Aug 14, 2016

@nucleartide Previous versions of Ember CLI already included the test loader in bower.json anyway (see https://github.com/ember-cli/ember-cli/blob/v2.6.3/blueprints/app/files/bower.json#L6), so I'm not sure why it was added here too. IMHO we can remove that line. Could you open a PR that removes it?

@Turbo87
Copy link
Member

Turbo87 commented Aug 14, 2016

actually, just removing it might not be such a great idea. we should try to mimic what has been done in ember-cli/ember-cli-qunit@115d56b instead.

@alexlafroscia
Copy link
Contributor

If I understand correctly, we should be able to add ember-cli-test-loader as a dependency of ember-cli-mocha and then expose it using the shouldIncludeChildAddon hook instead, allowing us to avoid adding the dependency to the consuming application entirely.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants