We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
https://github.com/rwjblue/ember-cli-version-checker/blob/bf010c726d0c3be9131fc25a2a247beb1f89895c/index.js#L62
Shouldn't this statement be: return semver.gte(this.version, compareVersion); to be inclusive of the version specified?
return semver.gte(this.version, compareVersion);
The text was updated successfully, but these errors were encountered:
in that case it should IMHO be named isAboveOrEqual().
isAboveOrEqual()
but you are correct that the deprecated static isAbove() method did it differently:
isAbove()
ember-cli-version-checker/index.js
Lines 121 to 125 in bf010c7
Sorry, something went wrong.
No branches or pull requests
https://github.com/rwjblue/ember-cli-version-checker/blob/bf010c726d0c3be9131fc25a2a247beb1f89895c/index.js#L62
Shouldn't this statement be:
return semver.gte(this.version, compareVersion);
to be inclusive of the version specified?The text was updated successfully, but these errors were encountered: