Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assertAbove throws error on exact match of version #16

Closed
jme783 opened this issue Feb 29, 2016 · 1 comment
Closed

assertAbove throws error on exact match of version #16

jme783 opened this issue Feb 29, 2016 · 1 comment
Labels

Comments

@jme783
Copy link

jme783 commented Feb 29, 2016

https://github.com/rwjblue/ember-cli-version-checker/blob/bf010c726d0c3be9131fc25a2a247beb1f89895c/index.js#L62

Shouldn't this statement be: return semver.gte(this.version, compareVersion); to be inclusive of the version specified?

@Turbo87
Copy link
Member

Turbo87 commented Dec 5, 2016

in that case it should IMHO be named isAboveOrEqual().

but you are correct that the deprecated static isAbove() method did it differently:

VersionChecker.isAbove = function deprecatedIsAbove(addon, comparisonVersion) {
var dependencyChecker = new EmberCLIDependencyVersionChecker(addon);
return dependencyChecker.satisfies('>=' + comparisonVersion);
};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants