Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolution can fail in yarn workspaces #93

Closed
pzuraq opened this issue Feb 13, 2019 · 5 comments
Closed

Resolution can fail in yarn workspaces #93

pzuraq opened this issue Feb 13, 2019 · 5 comments

Comments

@pzuraq
Copy link
Contributor

pzuraq commented Feb 13, 2019

In workspaces, when a package is hoisted and using ember-cli-version-checker, it can fail by accidentally checking the version in the root rather than the version in sub packages: ref

For now the solution appears to using nohoist on the offending package, but ideally we could figure out a way to tell what the correct resolution should be.

@rwjblue
Copy link
Member

rwjblue commented Feb 13, 2019

Thanks for reporting! I think the first step here would be creating a smallish reproduction, then we can figure out how normal require's within a JS file work. Then we can figure out where we are going wrong...

@pzuraq
Copy link
Contributor Author

pzuraq commented Feb 13, 2019

Repro here: https://github.com/betocantu93/monorepo-decorators, major thanks to @betocantu93!

@buschtoens
Copy link
Contributor

Didn't I fix this in #70? 🤔

@betocantu93
Copy link

betocantu93 commented Feb 13, 2019

I can confirm using @ember-decorators/babel-transforms 5.1.3 works, as suggested in #70, but right now ember install ember-decorators installs the 3.1.0 version

https://github.com/ember-decorators/ember-decorators/blob/23c55cc279f1e3715a742836a55c74883042feaa/packages/-ember-decorators/blueprints/ember-decorators/index.js#L74

@buschtoens
Copy link
Contributor

So I guess we can close this issue here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants