Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dummy app hitting recently added assertion #188

Merged
merged 1 commit into from
Oct 7, 2020

Conversation

raido
Copy link
Contributor

@raido raido commented Oct 7, 2020

Currently dummy app crashes due to assertion over here - d4ea9bb#diff-594a50941ede282499b14635c267e13fR248

But this exceptional case, because we intentionally include title elements twice to test Fastboot + Browser scenarios together.

@knownasilya knownasilya merged commit cba2987 into ember-cli:master Oct 7, 2020
@knownasilya
Copy link
Contributor

@raido want to be added to the page-title team on github?

@raido raido deleted the fix-dummy-app-title-assertion branch October 8, 2020 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants